Add dynamic whitelisting #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Nov 14, 2024
src/util/swapHelpers.ts
Outdated
| // Map of swap provider's chain codes and the tokens they support | ||
| export type ChainCodeTickerMap = Map< | ||
| string, | ||
| Set<{ tokenCode: string; contractAddress: string | null }> |
There was a problem hiding this comment.
There is no point in making this a Set, since the objects inside won't be de-duplicated. It could be a plain array, or it be a Map from token code to contract address. Since createEdgeIdToSwapIdMap just loops over it, probably the Array is better.
swansontec
approved these changes
Nov 14, 2024
Use getTokenId on currencyConfig instead
"Draw the rest of the fucking owl" The goal is to map the swap provider's chain/token code combo to EdgeTokenIds without causing too much of a slow down by adding unnecessary fetches. To accomplish this, we can grab the data from the provider once and hold them in memory indefinitely as `chainCodeTickerMap`. We'll convert the cached data As requests are made, we map that cached data to EdgeTokenIds using `getTokenId` which is available on the wallets in the request.
peachbits
force-pushed
the
matthew/whitelist
branch
from
88c0d77 to
2014413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none