Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rango: Add Solana support #354

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

Ikari-Shinji-re
Copy link
Contributor

@Ikari-Shinji-re Ikari-Shinji-re commented Dec 2, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

note :

In my tests, selecting a non-native token from the Solana blockchain and entering a value below my maximum balance resulted in an "insufficient balance" error. However, using the "max" button worked without any issues.


Copy link
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I also tested the code with EVM and Solana swaps and it's working as expected.

@peachbits peachbits merged commit b9718f3 into EdgeApp:master Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants