Fix FIO Request Crypto Text Multiplier #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/fio-req-denom
branch
from
6c77416
to
cfeeca3
Compare
paullinator
approved these changes
Aug 31, 2023
|
Good cleanup and implementation |
The original "useCryptoText" wasn't actually a hook to begin with. "useCryptoTextSimple" was the real hook. - Rename/move useCryptoText->getCryptoText in a separate cryptoTextUtils.ts - Rename/move useCryptoTextSimple->useCryptoText, move to useCryptoText.ts
The FioRequest interface represents crypto amounts in "typical" amount multipliers as seen in any modern crypto website/product/social verbiage - i.e. "1.23 BTC." These are known in Edge as "exchange" denomination multipliers. Properly factor in the "exchangeDenomination" (described above) and "displayDenomination" (user denom/mult setting) in the FioRequestRow crypto amount
Jon-edge
force-pushed
the
jon/fio-req-denom
branch
from
cfeeca3
to
5954b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FioRequest interface represents crypto amounts in "typical" amount multipliers as seen in any modern crypto website/product/social verbiage - i.e. "1.23 BTC." These are known in Edge as "exchange" denomination multipliers.
Properly factor in the "exchangeDenomination" (described above) and "displayDenomination" (user denom/mult setting) in the FioRequestRow crypto amount
CHANGELOG
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: