Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FIO Request Crypto Text Multiplier #4422

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fix FIO Request Crypto Text Multiplier #4422

merged 3 commits into from
Aug 31, 2023

Commits on Aug 31, 2023

  1. Adjust UseCryptoTextParams

    @Jon-edge
    Jon-edge committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    98a682a View commit details
    Browse the repository at this point in the history

  2. Rename fns and vars to be more accurate and descriptive 

    The original "useCryptoText" wasn't actually a hook to begin with. "useCryptoTextSimple" was the real hook.

- Rename/move useCryptoText->getCryptoText in a separate cryptoTextUtils.ts
- Rename/move useCryptoTextSimple->useCryptoText, move to useCryptoText.ts
    @Jon-edge
    Jon-edge committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    245ca3a View commit details
    Browse the repository at this point in the history

  3. Properly convert FIO amount denom/multiplier 

    The FioRequest interface represents crypto amounts in "typical" amount multipliers as seen in any modern crypto website/product/social verbiage - i.e. "1.23 BTC." These are known in Edge as "exchange" denomination multipliers.

Properly factor in the "exchangeDenomination" (described above) and "displayDenomination" (user denom/mult setting) in the FioRequestRow crypto amount
    @Jon-edge
    Jon-edge committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5954b75 View commit details
    Browse the repository at this point in the history