CoinZark Swap Plugin #1349
Closed
CoinZark Swap Plugin #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
May 2, 2019
env.example.json
Outdated
| @@ -24,6 +24,10 @@ | |||
| "affiliateId": "xxxx", | |||
| "affiliateMargin": 0.5 | |||
| }, | |||
| "x_COINZARK_INIT": { | |||
| "apiKey": "xxxx", | |||
| "affiliateMargin": 0.5 | |||
There was a problem hiding this comment.
The plugin itself seems to be using affiliateId and affiliateFee here. Is this right?
There was a problem hiding this comment.
Good catch. This was indeed incorrect in the sample. Changed that.
swansontec
approved these changes
May 8, 2019
|
I rebased this branch on top of our latest development, and pushed it to: https://github.com/EdgeApp/edge-react-gui/tree/coinzark. When you are ready to do the integration again, please use that branch as a starting point. |
|
We are closing this out, since it has falling behind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the changes for the integration of CoinZark as an Exchange provider in the Edge wallet. See also The related PR in
edge-exchange-pluginsPR Requirements
If you have made any visual changes to the GUI. Make sure you have: