Audit every catch statement in the codebase
#1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/error-insanity
branch
3 times, most recently
from
32f0045 to
f141829
Compare
swansontec
force-pushed
the
william/error-insanity
branch
2 times, most recently
from
7b972e2 to
6b48c7c
Compare
swansontec
force-pushed
the
william/error-insanity
branch
from
6b48c7c to
6e9f5d9
Compare
swansontec
commented
Sep 24, 2019
| @@ -7,30 +7,20 @@ import type { Dispatch, GetState } from '../types/reduxTypes.js' | |||
| export const enableOtp = () => async (dispatch: Dispatch, getState: GetState) => { | |||
| const state = getState() | |||
| const account = CORE_SELECTORS.getAccount(state) | |||
| try { | |||
There was a problem hiding this comment.
We don't need try/catch here because the dispatch includes that by default for all actions, but I would be OK putting these back to catch (error) { showError(error) }
thehobbit85
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Requirements
If you have made any visual changes to the GUI. Make sure you have: