Add swap error logging to Sentry #5322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Oct 25, 2024
6 tasks
The error captured should always be of type `Error` some stack traces can be included. We cast unexpected error types to String and include that in the unknown error message.
We'll capture these warning type errors using Sentry's API. We'll include details relevant for the swap for indexing purposes, but NEVER include personal or sensitive information from the user's activity.
By using the context object, we allow for error name/message information to be indexed properly in Sentry without losing the contextual information that comes along with the error.
samholmes
force-pushed
the
sam/swap-error-tracking
branch
from
ae2d611
to
80cfc4e
Compare
samholmes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: