Skip to content

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented Sep 30, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Refactors SimpleTextInput animations/styles and submit behavior, adjusts hitSlop/cancel UI, and updates affected snapshots.

  • UI/Theming:
    • SimpleTextInput refactor (src/components/themed/SimpleTextInput.tsx):
      • Replace styled HOCs with cacheStyles and inline Reanimated styles; compute colors via new interpolate helpers.
      • Icon visibility now animates with transform: scale and margin shifts instead of width/opacity sizing.
      • Render TextInput directly with animated color; add submitBehavior control and set blurOnSubmit default to false; expose onSubmitEditing at top-level.
      • Increase clear-button hitSlop and adjust back/cancel UI (iOS cancel uses styled UnscaledText).
  • Tests:
    • Update snapshots for Wallet List Modal, Create Wallet Select Crypto, and Default Fiat Setting scenes to reflect layout/animation and hitSlop changes.

Written by Cursor Bugbot for commit 0fa8cff. This will update automatically on new commits. Configure here.


padding: theme.rem(1),
margin: -theme.rem(1)
}))
rightIconTouchable: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're already applying hitSlop so this seems redundant

The `styled` HOC is really hard to reason about, which is blocking the layout changes we need to make.
@swansontec swansontec enabled auto-merge October 9, 2025 18:09
@swansontec swansontec merged commit 00eab71 into develop Oct 9, 2025
2 checks passed
@swansontec swansontec deleted the william/text-input branch October 9, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants