Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Oct 29, 2025

image

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Fixes sell amount direction/formatting and refactors QuoteResult to handle provider-specific quotes grouped by payment type.

  • UI (Ramp Select Option):
    • Refactors QuoteResult to accept providerQuotes, manage providerQuoteIndex, and update press handlers/modal selection accordingly.
    • Fixes totalAmount rendering to show fiat→crypto for buy and crypto→fiat for sell.
    • Updates best-option check, payment type icon/title, and partner details to use the selected providerQuote.
  • Scene Rendering:
    • Iterates quotesByPaymentType entries and passes grouped providerQuotes to QuoteResult.

Written by Cursor Bugbot for commit b6eab78. This will update automatically on new commits. Configure here.


Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like to see big changes like the renaming in staging, but it seems safe enough we can still merge it.

@Jon-edge Jon-edge force-pushed the jon/fix/sell-amount-display branch from e911c63 to b6eab78 Compare October 31, 2025 23:27
@Jon-edge Jon-edge merged commit 2c2b2c7 into develop Oct 31, 2025
2 of 3 checks passed
@Jon-edge Jon-edge deleted the jon/fix/sell-amount-display branch October 31, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants