Skip to content

Conversation

@samholmes
Copy link
Contributor

@samholmes samholmes commented Oct 29, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)


Note

Adds BitsOfGold and LibertyX ramp providers via a new external plugin framework, and updates quote handling/UI to support provider-redirect quotes without amounts.

  • Ramps:
    • New external ramp framework: createExternalRampPlugin with settlement/payment config and deep-linking to provider WebViews.
    • New providers: bitsofgold and libertyx plugins added and registered; env config supports their init options.
  • Quotes & UI:
    • Quote model: Add specialQuoteRateMessage to RampQuote and display via getRateFromRampQuoteResult when no amounts.
    • Sorting & selection: useRampQuotes prioritizes quotes with amounts; scenes guard against zero/absent amounts and adjust max-quote logic.
    • UI updates: Show formatted amounts when available; fallback messages ("Select to view quote" / "Failed to calculate quote rate") when not; improved best-option checks.
  • Localization: Add new strings for no-amount quote states.
  • CHANGELOG: Note added providers.

Written by Cursor Bugbot for commit 59e7f14. This will update automatically on new commits. Configure here.

user_closed_modal_no_wallet: 'User closed modal. No wallet was selected',
plugin_powered_by_space: 'Powered by ',
tap_to_change_provider: 'Tap to Change Provider',
tap_to_view_quote_amount_and_rate: 'Tap to view quote amounts and rates',
Copy link
Collaborator

@Jon-edge Jon-edge Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid "Tap to X." We don't want our app to be littered with "Tap to do this," "Tap to do that" - we might as well be a 90's web page with underlined blue links.

Ideally it's the UI/UX design's job to communicate tappability clearly, but suggest "Select to view quote" at as a slightly better copy

Copy link
Collaborator

@Jon-edge Jon-edge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least integrate the lstrings suggestion

cursor[bot]

This comment was marked as outdated.

@samholmes samholmes disabled auto-merge November 4, 2025 00:02
@samholmes samholmes enabled auto-merge November 4, 2025 00:15
@samholmes samholmes merged commit 1d830f8 into develop Nov 4, 2025
3 checks passed
@samholmes samholmes deleted the sam/bog-libx branch November 4, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants