Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Oct 29, 2025

This happens because useRampQuotes calls runWithTimeout for 10 seconds. If that timeout triggers, we show an error card in place of the payment method.

Fix to increase the delay, only ever show one error card, and also notify the user to check their network connection.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Consolidates ramp errors to a single non‑fiat error card when no quotes are available, increases quote fetch timeout to 15s, and updates generic error copy to mention network connectivity.

  • Ramp UI (src/components/scenes/RampSelectOptionScene.tsx):
    • Only display one ErrorCard for the first non-FiatProviderError when allQuotes.length === 0.
    • Memoize nonFiatErrors filtered from failedQuotes.
  • Quotes Fetching (src/hooks/useRampQuotes.ts):
    • Increase runWithTimeout for plugin.fetchQuotes from 10000 to 15000 ms.
  • Localization (src/locales/en_US.ts, src/locales/strings/enUS.json):
    • Update error_generic_message to: “An unexpected error occurred. Please check your network connection and try again later.”

Written by Cursor Bugbot for commit 7a14b27. This will update automatically on new commits. Configure here.


@Jon-edge Jon-edge force-pushed the jon/fix/ramp-error-cards branch from 894144a to e4dc035 Compare October 30, 2025 23:21
@Jon-edge Jon-edge force-pushed the jon/fix/ramp-error-cards branch from e4dc035 to 2ad26bb Compare October 31, 2025 22:57
This happens because `useRampQuotes` calls `runWithTimeout` for 10 seconds. If that timeout triggers, we show an error card in place of the payment method.

Fix to increase the delay, only ever show one error card, and also notify the user to check their network connection.
@Jon-edge Jon-edge force-pushed the jon/fix/ramp-error-cards branch from 2ad26bb to 7a14b27 Compare October 31, 2025 23:31
@Jon-edge Jon-edge merged commit 538dfcc into develop Oct 31, 2025
2 of 3 checks passed
@Jon-edge Jon-edge deleted the jon/fix/ramp-error-cards branch October 31, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants