Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acronym spacing #37

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Acronym spacing #37

merged 1 commit into from
Sep 6, 2022

Conversation

microraptor
Copy link
Contributor

Here is one last minor improvement suggestions from me. I noticed that the pacing of acronyms sounds weird in the generated files. Trying it out at the online demo Generator, I personally think the acronym pacing sound much better, if we don't use spaces between letters. So OSD, VTX, etc. instead of "O S D", "V T X". This seems especially important for longer phrases ("VTX 400 milliwatts"). However, this is very subjective. My apologies for not testing this before audio files were generated, because quite a few of them were in my actually in my PR.

If you decide to merge this, these are the audio files, which would be affected by the change:

en-GB and en-US:
"146","DB","DB","","SYSTEM","db0.wav"
"147","DB","DB","","SYSTEM","db1.wav"
"148","RPM","RPM","","SYSTEM","rpm0.wav"
"149","RPM","RPM","","SYSTEM","rpm1.wav"
"322","OSD","OSD","video","","osd.wav"
"323","OSD profile","OSD profile","video","","osdprf.wav"
"336","OSD Profile 1","OSD Profile 1","video","","osd1.wav"
"337","OSD Profile 2","OSD Profile 2","video","","osd2.wav"
"338","OSD Profile 3","OSD Profile 3","video","","osd3.wav"
"350","VTX","VTX","video","","vtx.wav"
"351","VTX on","VTX on","video","","vtxon.wav"
"352","VTX off","VTX off","video","","vtxoff.wav"
"353","VTX 25 milliwatts","VTX 25 milliwatts","video","","vtx25.wav"
"354","VTX 50 milliwatts","VTX 50 milliwatts","video","","vtx50.wav"
"355","VTX 100 milliwatts","VTX 100 milliwatts","video","","vtx100.wav"
"356","VTX 200 milliwatts","VTX 200 milliwatts","video","","vtx200.wav"
"357","VTX 300 milliwatts","VTX 300 milliwatts","video","","vtx300.wav"
"358","VTX 400 milliwatts","VTX 400 milliwatts","video","","vtx400.wav"
"359","VTX 500 milliwatts","VTX 500 milliwatts","video","","vtx500.wav"
"360","VTX 600 milliwatts","VTX 600 milliwatts","video","","vtx600.wav"
"361","VTX 700 milliwatts","VTX 700 milliwatts","video","","vtx700.wav"
"362","VTX 800 milliwatts","VTX 800 milliwatts","video","","vtx800.wav"
"363","VTX 900 milliwatts","VTX 900 milliwatts","video","","vtx900.wav"
"364","VTX Pit Mode","VTX Pit Mode","video","","vtxpm.wav"
"365","VTX Race Mode","VTX Race Mode","video","","vtxrm.wav"
"366","VTX 1 watt","VTX 1 watt","video","","vtx1w.wav"
"367","VTX 2 watts","VTX 2 watts","video","","vtx2w.wav"
"368","VTX 4 watts","VTX 4 watts","video","","vtx4w.wav"
"375","dynamic TX power","dynamic TX power","rc-link","","dyntxp.wav"
"376","maximum TX power","maximum TX power","rc-link","","maxtxp.wav"
"388","FPV angle mix active","FPV angle mix active","multicopter","","agmxon.wav"
"389","FPV angle mix off","FPV angle mix off","multicopter","","agmxof.wav"
"392","OSD on","OSD on","video","","osdon.wav"
"393","OSD off","OSD off","video","","osdoff.wav"

ja-JP:
"148","RPM","RPM","","SYSTEM","rpm0.wav"
"149","RPM","RPM","","SYSTEM","rpm1.wav"
"322","OSD","OSD","","","osd.wav"
"323","OSD profile","OSD プロファイル","","","osdprf.wav"

it-IT:
"146","DB","DB","","SYSTEM","db0.wav"
"147","DB","DB","","SYSTEM","db1.wav"
"148","RPM","RPM","","SYSTEM","rpm0.wav"
"149","RPM","RPM","","SYSTEM","rpm1.wav"

pt-PT:
"140","RPM","RPM","","SYSTEM","rpm0.wav"

es-ES:
"139","DB","DB","","SYSTEM","db0.wav"
"140","RPM","RPM","","SYSTEM","rpm0.wav"

fr-FR:
"141","DB","DB","","SYSTEM","db0.wav"

de-DE:
"132","DB","DB","","SYSTEM","db0.wav"

@pfeerick
Copy link
Member

pfeerick commented Sep 6, 2022

Hm... strange... I did random sample of

V T X on
VTX on

V T X 600 milliwatts
VTX 600 milliwatts

dynamic T X power
dynamic TX power

F P V angle mix active
FPV angle mix active

O S D on
OSD on

D B
DB

R P M
RPM

and didn't notice any difference... but this was with Irish Emily... was there a particular speaker that was more prone to space it out?

Scratch that... Libby seems to like saying it consistently, but UK and US space it out. 🤦

@pfeerick pfeerick merged commit b60ee38 into EdgeTX:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants