Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates to Japanese CSV and sound file 🇯🇵 #39

Merged
merged 7 commits into from
Sep 12, 2022
Merged

chore: Updates to Japanese CSV and sound file 🇯🇵 #39

merged 7 commits into from
Sep 12, 2022

Conversation

ToshihiroMakuuchi
Copy link
Contributor

Because en-US.csv had been updated, ja-JP.csv and Japanese sound files were updated.

@pfeerick
Copy link
Member

pfeerick commented Sep 6, 2022

I just pushed a change that removes the spaces from some the acronyms - ie. "R P M" => "RPM", "V T X on" => "VTX on". Would you mind updating this to suit? Thanks ;)

@pfeerick pfeerick changed the title Japanese CSV and sound file updates chore: Updates to Japanese CSV and sound file 🇯🇵 Sep 8, 2022
@ToshihiroMakuuchi
Copy link
Contributor Author

@pfeerick
Sorry for the late response.
I have re-created the CSV file with the latest version. I have also merged the added content.

@pfeerick pfeerick reopened this Sep 10, 2022
@pfeerick
Copy link
Member

Very much appreciated. I know I can't just assume removing the spaces all that is needed ;)

@pfeerick pfeerick merged commit c06b78a into EdgeTX:main Sep 12, 2022
@ToshihiroMakuuchi ToshihiroMakuuchi deleted the ToshihiroMakuuchi/jp-fix branch September 13, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants