Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GT911): Add CLI command to reset touch panel config #2351

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Conversation

raphaelcoeffic
Copy link
Member

Related to #2063

@raphaelcoeffic
Copy link
Member Author

raphaelcoeffic commented Sep 24, 2022

@wimalopaan it seems the config can be perfectly reseted with this CLI command.

On my TX16S, this leads to the following output:

> reset_gt911
GT911: old config version is 65
GT911: new config version is 0

On the next reboot, the config number read is 65 ('A'), as I had GT911_CFG_NUMBER set to 'A' for test purposes.

@wimalopaan
Copy link
Contributor

Thats great! I had no luck with that on my controller ... and I verified all communication with a LogicAnalyzer. But anyway, very cool to have the intercative setting command!

@raphaelcoeffic
Copy link
Member Author

This has been tested today on a X12S and allows for removing the software inversion. For those who installed @wimalopaan ’s builds, it might work already (when software inversion is gone), for the others, a config reset via CLI will be needed.

@raphaelcoeffic
Copy link
Member Author

I’ll try to have something more “automatic” if I get to it, but that should already release the pain.

@pfeerick
Copy link
Member

Given how often this would be needed, this should be enough. And/or we add a button to the hardware tab (for that radio, if touchscreen enabled) to reset the touchscreen config (might also be good to show the current setting on the diags screen)...

@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review September 25, 2022 06:06
@pfeerick pfeerick added enhancement ✨ New feature or request touch 👆 Related to touch interface labels Sep 25, 2022
@pfeerick
Copy link
Member

FWIW, mine was 109 ... I won't make any IQ jokes as I'll surely lose! 🤣

explorer_Y3GzZe1NsO.mp4

@raphaelcoeffic
Copy link
Member Author

FWIW, mine was 109

This is normal, see current definition:

#define GT911_CFG_NUMBER        0x6D

@pfeerick
Copy link
Member

pfeerick commented Sep 25, 2022

Perfect! :) I'll leave it for a day to give Kevin from the related issue a chance to respond, and then merge. Actually, scratch that... it can get merged now...

@pfeerick pfeerick changed the title GT911: add CLI command to reset config feat(GT911): Add CLI command to reset touch panel config Sep 25, 2022
@pfeerick pfeerick merged commit 78e9931 into main Sep 25, 2022
@pfeerick pfeerick deleted the reset-gt911 branch September 25, 2022 10:27
@raphaelcoeffic raphaelcoeffic mentioned this pull request Sep 26, 2022
12 tasks
@rotorman rotorman mentioned this pull request Nov 7, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request touch 👆 Related to touch interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants