-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for FRM303, enhancement 2863 #2875
Conversation
I have successfully added support FRM303, and it works in my EL18. This change will not affect the MPM, the MPM is ok as well. @raphaelcoeffic There are 2 points may need to check:
|
Besides Flysky radio, I think it may not work on TX16S because of the buggy MB that frozen the Heartbeat pin. However even the heartbeat works, it will forces the TX/RX to be inverted, right? |
be7b313
to
144d16a
Compare
Rebased after module-api merged. Need to test again later this week. |
@richardclli other than the extra line, I'm good with it, let's have this module supported! |
@raphaelcoeffic However, I discovered something bad when testing it. A crash occurs when using the internal IRM301 alone and did not plug in the FRM303. Not sure why. It works ok without my changes. And the same changes works in 2.8 branch as well. |
285f8e0
to
ad04f28
Compare
The crash is finally fixed. It works now for both int module IRM301 and ext module FRM303. |
@pfeerick This should be ready to merge to main. |
Just to confirm, when merged, FRM303 works with EL18 only and not TX16s? |
Yes, not worked for now, hardware limitations. Need Flysky to work out another serial connection mode in FRM303, before we can work on the support for other radios. TX16S mk1 has bugged heartbeat line, and besides this bug, softserial required as the signal is non-inverted, while TX16S forced invert the PPM and heartbeat line. Therefore best solutions is to make use the S.Port line for half-duplex communication. |
Is it possible in the future? |
Sure will work in the future. |
Fixes #2863
Summary of changes: