Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for FRM303, enhancement 2863 #2875

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Conversation

richardclli
Copy link
Collaborator

Fixes #2863

Summary of changes:

@richardclli richardclli marked this pull request as draft December 16, 2022 07:34
@richardclli
Copy link
Collaborator Author

I have successfully added support FRM303, and it works in my EL18. This change will not affect the MPM, the MPM is ok as well.

@raphaelcoeffic There are 2 points may need to check:

  1. The current FRM303 uses normal TX/RX while the MPM uses inverted TX, I just put the code in the init and deinit of the ext AFHDS3 module.
  2. The ext FRM303 and int IRM301 uses different framing address, not sure if we need to put the selection in the UI as well.

@richardclli
Copy link
Collaborator Author

richardclli commented Dec 16, 2022

Besides Flysky radio, I think it may not work on TX16S because of the buggy MB that frozen the Heartbeat pin. However even the heartbeat works, it will forces the TX/RX to be inverted, right?

@pfeerick pfeerick marked this pull request as ready for review January 3, 2023 09:59
@richardclli richardclli changed the title Added support for FRM303. Added support for FRM303, enhancement 2863 Jan 13, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jan 17, 2023
@pfeerick pfeerick added enhancement ✨ New feature or request hardware support labels Jan 17, 2023
@pfeerick pfeerick self-assigned this Jan 17, 2023
@pfeerick pfeerick removed their assignment Feb 3, 2023
@richardclli richardclli marked this pull request as draft February 10, 2023 02:22
@richardclli
Copy link
Collaborator Author

Rebased after module-api merged. Need to test again later this week.

@raphaelcoeffic
Copy link
Member

@richardclli other than the extra line, I'm good with it, let's have this module supported!

@richardclli
Copy link
Collaborator Author

richardclli commented Feb 10, 2023

@raphaelcoeffic However, I discovered something bad when testing it. A crash occurs when using the internal IRM301 alone and did not plug in the FRM303. Not sure why. It works ok without my changes. And the same changes works in 2.8 branch as well.

@richardclli
Copy link
Collaborator Author

The crash is finally fixed. It works now for both int module IRM301 and ext module FRM303.

@richardclli
Copy link
Collaborator Author

@pfeerick This should be ready to merge to main.

@pfeerick pfeerick marked this pull request as ready for review February 22, 2023 05:03
@pfeerick pfeerick self-assigned this Feb 22, 2023
@pfeerick pfeerick merged commit 4547f08 into main Feb 27, 2023
@pfeerick pfeerick deleted the FRM303-support-2863 branch February 27, 2023 11:51
@jmxp69
Copy link

jmxp69 commented Mar 7, 2023

Just to confirm, when merged, FRM303 works with EL18 only and not TX16s?

@richardclli
Copy link
Collaborator Author

richardclli commented Mar 8, 2023

Yes, not worked for now, hardware limitations. Need Flysky to work out another serial connection mode in FRM303, before we can work on the support for other radios. TX16S mk1 has bugged heartbeat line, and besides this bug, softserial required as the signal is non-inverted, while TX16S forced invert the PPM and heartbeat line. Therefore best solutions is to make use the S.Port line for half-duplex communication.

@xiaoyigg
Copy link

xiaoyigg commented Mar 8, 2023

Is it possible in the future?

@richardclli
Copy link
Collaborator Author

Sure will work in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Flysky FRM303
5 participants