Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PUT method for deviceshifu OPCUA and MQTT to write data #1004

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Oct 12, 2024

What this PR does / why we need it:
enable PUT method for deviceshifu OPCUA and MQTT to write data
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

@rhoninl rhoninl marked this pull request as ready for review October 12, 2024 08:37
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.60%. Comparing base (1d41155) to head (7c6adba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...g/deviceshifu/deviceshifuopcua/deviceshifuopcua.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files          46       46           
  Lines        2976     2978    +2     
=======================================
+ Hits         1119     1120    +1     
- Misses       1737     1739    +2     
+ Partials      120      119    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit bcc7695 into main Oct 14, 2024
14 of 15 checks passed
@tomqin93 tomqin93 deleted the put_for_opcua_and_mqtt branch October 14, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants