Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer configuration #1005

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update devcontainer configuration #1005

merged 1 commit into from
Oct 14, 2024

Conversation

tomqin93
Copy link
Contributor

What this PR does / why we need it:
This PR updates the devcontainer image, remove docker building phase

Will this PR make the community happier?
Yes

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • manually tested

Special notes for your reviewer:

Release note:

- update devcontainer image
- update devcontainer configuration with more vscode extensions
- remove Docker building phase when using devcontainer
- remove unnecessary configuration for devcontainer

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.70%. Comparing base (1d41155) to head (3a81d34).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   37.60%   37.70%   +0.10%     
==========================================
  Files          46       46              
  Lines        2976     2976              
==========================================
+ Hits         1119     1122       +3     
+ Misses       1737     1735       -2     
+ Partials      120      119       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93 tomqin93 merged commit 2983449 into main Oct 14, 2024
6 checks passed
@tomqin93 tomqin93 deleted the devcontainer-update branch October 14, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants