Add lwm2m deviceshifu design #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 37.33% 37.63% +0.30%
==========================================
Files 46 46
Lines 3544 2976 -568
==========================================
- Hits 1323 1120 -203
+ Misses 2105 1737 -368
- Partials 116 119 +3 ☔ View full report in Codecov by Sentry. |
kris21he
reviewed
Oct 9, 2024
|
|
||
| The `deviceShifu-LwM2M` will represent each LwM2M object as an instruction that can be accessed through a RESTful API. The API will use the POST method for write operations and the GET method for read operations. The supported data formats for LwM2M v1.0 are TLV, JSON, Plain text, and Opaque. | ||
|
|
||
| deviceShifu-LwM2M's LwM2M server will handle Register, Update, De-register, Read, Write, Observe and Notify. |
There was a problem hiding this comment.
Register, Update, De-register, Read, Write, Observe and Notify. there are some typo and duplication in this text.
correct one FYI:
Register, Un-register, Read, Write, Observe and Notify.
There was a problem hiding this comment.
In the official lwM2M documentation, it is named this way.
kris21he
reviewed
Oct 9, 2024
kris21he
reviewed
Oct 9, 2024
kris21he
reviewed
Oct 9, 2024
kris21he
reviewed
Oct 9, 2024
kris21he
reviewed
Oct 10, 2024
|
@rhoninl one more typo? please check, others LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
lwM2M deviceShifu design doc
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #How is this PR tested
documentation no need test
Special notes for your reviewer:
Release note: