Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #994] Fix inconsistent SQL Server E2E test #995

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

tomqin93
Copy link
Contributor

@tomqin93 tomqin93 commented Oct 1, 2024

…mages

What this PR does / why we need it:
This PR adds a godebug option to fix sql server e2e test
microsoft/mssql-docker#895

Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #994

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

- added godebug flag with x509negativeserial=1 to allow certificates with negative serial number

@tomqin93 tomqin93 merged commit 563ab12 into main Oct 1, 2024
12 of 13 checks passed
@tomqin93 tomqin93 deleted the issue_994-sql-server-e2e-fix branch October 1, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent SQL Server E2E test
3 participants