Skip to content

Commit

Permalink
Add useSyncExternalStore and useTransition to getPrimitiveStackCache (f…
Browse files Browse the repository at this point in the history
…acebook#28399)

<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`,
open `chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

<!--
Explain the **motivation** for making this change. What existing problem
does the pull request solve?
-->

This solves the problem of the devtools extension failing to parse hook
names for components that make use of `useSyncExternalStore` or
`useTransition`.

See facebook#27889 

## How did you test this change?

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->

I tested this against my own codebases and against the example repro
project that I linked in facebook#27889.

To test, I opened up the Components tab of the dev tools extension,
selected a component with hooks that make use of `useSyncExternalStore`
or `useTransition`, clicked the "parse hook names" magic wand button,
and observed that it now succeeds.
  • Loading branch information
jamesbvaughan authored and AndyPengc12 committed Apr 15, 2024
1 parent ea6c89c commit 6d7f4ac
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
7 changes: 7 additions & 0 deletions packages/react-debug-tools/src/ReactDebugHooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ function getPrimitiveStackCache(): Map<string, Array<any>> {
Dispatcher.useImperativeHandle(undefined, () => null);
Dispatcher.useDebugValue(null);
Dispatcher.useCallback(() => {});
Dispatcher.useTransition();
Dispatcher.useSyncExternalStore(
() => () => {},
() => null,
() => null,
);
Dispatcher.useDeferredValue(null);
Dispatcher.useMemo(() => null);
if (typeof Dispatcher.useMemoCache === 'function') {
// This type check is for Flow only.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ describe('ReactHooksInspectionIntegration', () => {
"hookSource": {
"columnNumber": 0,
"fileName": "**",
"functionName": null,
"functionName": "Foo",
"lineNumber": 0,
},
"id": 0,
Expand Down Expand Up @@ -986,7 +986,7 @@ describe('ReactHooksInspectionIntegration', () => {
"hookSource": {
"columnNumber": 0,
"fileName": "**",
"functionName": null,
"functionName": "Foo",
"lineNumber": 0,
},
"id": 0,
Expand Down Expand Up @@ -1969,7 +1969,7 @@ describe('ReactHooksInspectionIntegration', () => {
"hookSource": {
"columnNumber": 0,
"fileName": "**",
"functionName": null,
"functionName": "Foo",
"lineNumber": 0,
},
"id": 0,
Expand Down

0 comments on commit 6d7f4ac

Please sign in to comment.