Skip to content

Commit

Permalink
Update fork for ReactSharedInternalsClient export (facebook#27717)
Browse files Browse the repository at this point in the history
## Summary

After changes in facebook#27436, UMD
builds no longer expose Scheduler from ReactSharedInternals. This module
is forked in rollup for UMD builds and the path no longer matches. This
PR updates the path name to match the new module:
ReactSharedInternalsClient.

## How did you test this change?

- `yarn build`
- Inspect `react.development.js` UMD build, observe `Scheduler:
Scheduler` is set in `ReactSharedInternals`, matching
[18.2.0](https://unpkg.com/react@18.2.0/umd/react.development.js)
- ran attribute-behavior fixture app
- Observe no more error `Uncaught (in promise) TypeError: Cannot read
properties of undefined (reading 'unstable_cancelCallback')`

Co-authored-by: Jack Pope <jackpope@meta.com>
  • Loading branch information
jackpope and Jack Pope authored Nov 17, 2023
1 parent 1a65d03 commit bbb9cb1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/rollup/forks.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ const forks = Object.freeze({
}
},

'./packages/react/src/ReactSharedInternals.js': (bundleType, entry) => {
'./packages/react/src/ReactSharedInternalsClient.js': (bundleType, entry) => {
switch (bundleType) {
case UMD_DEV:
case UMD_PROD:
Expand Down

0 comments on commit bbb9cb1

Please sign in to comment.