Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for fully-qualified domain names #10

Closed
Chaz6 opened this issue Dec 14, 2021 · 5 comments
Closed

Support for fully-qualified domain names #10

Chaz6 opened this issue Dec 14, 2021 · 5 comments
Assignees
@Edu4rdSHL
Labels
enhancement New feature or request fixed

Comments

@Chaz6
Copy link

Chaz6 commented Dec 14, 2021

At present, no results are returned when supplying a fully-qualified domain name:-

$ echo www.example.com. | rusolver

$ echo www.example.com | rusolver
www.example.com
@Edu4rdSHL
Copy link
Owner

Rusolver use FQDNs by default.

@Chaz6
Copy link
Author

Chaz6 commented Dec 15, 2021

This means it is not possible to pass a proper fqdn to rusolver.

@Edu4rdSHL
Copy link
Owner

Right, it isn't gonna change.

Edu4rdSHL added a commit that referenced this issue Dec 15, 2021
@Edu4rdSHL
Support for fully-qualified domain names
ddd0557 
Fixes #10

Signed-off-by: Edu4rdSHL <edu4rdshl@protonmail.com>
@Edu4rdSHL
Copy link
Owner

The previous commit should fix it, please can you test?

@Edu4rdSHL Edu4rdSHL reopened this Dec 15, 2021
@Chaz6
Copy link
Author

Chaz6 commented Dec 15, 2021

Looks good to me!

$ echo www.example.com | rusolver
www.example.com
$ echo www.example.com. | rusolver
www.example.com.

Thank you 🤝

@Edu4rdSHL Edu4rdSHL added the enhancement New feature or request label Dec 15, 2021
@Edu4rdSHL Edu4rdSHL self-assigned this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Edu4rdSHL Edu4rdSHL

Labels
enhancement New feature or request fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chaz6 @Edu4rdSHL