Do CI/CD on fixed JDK version and use Zulu instead of Adopt or Temurin #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
============================================
- Coverage 51.08% 51.07% -0.02%
+ Complexity 1443 1442 -1
============================================
Files 249 249
Lines 9870 9870
Branches 1092 1092
============================================
- Hits 5042 5041 -1
Misses 4510 4510
- Partials 318 319 +1
Continue to review full report at Codecov.
|
|
Thanks for your contribution! I'm trying to understand why the workflows are failing, and after that I'll remove the required statuses (since their name is changed) and merge your PR. |
|
The checks are failing because of #617, not because of the changes themselves. I am merging the PR. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fixed JDK 11 version for your CI/CD pipeline so that you have a specific version to do setup-java against. If the pipeline against the latest JDK version fails while it continues to succeed against the fixed version, you'll know that the build failure is related to the latest JDK 11 version and not to an error in your code.
Also, since Adopt is no more, the alternative JDK distros to use are Temurin and Zulu, though Temurin doesn't provide all the JDK versions since it is new, while Zulu has a more complete set of JDKs, useful for using fixed versions, so switched from Adopt to Temurin to Zulu.