fix: do not wipe EX on FP-induced WAW stalls #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
============================================
+ Coverage 51.07% 51.09% +0.02%
- Complexity 1442 1443 +1
============================================
Files 249 249
Lines 9870 9879 +9
Branches 1092 1092
============================================
+ Hits 5041 5048 +7
- Misses 4510 4512 +2
Partials 319 319
Continue to review full report at Codecov.
|
This test would have exposed the second reoccurrence of issue #304. Thanks to @hugmanrique for this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #305 (which originally fixed #304), add a check on whether
EX is empty before inserting a BUBBLE instruction.
Also add some more verbose logging to help reason about the flow
without having to use a debugger.
Fixes #304.