Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in Assignment 2 (step-by-step) #6

Merged
merged 3 commits into from
Jun 27, 2021

Conversation

mthmulders
Copy link
Contributor

@mthmulders mthmulders commented Jun 27, 2021

Three minor textual changes:

  • All other "Step" headers were at H2, only this one at H3
  • I believe the text referred to the wrong application: it read FineCollectionService, but that's the application where the students are working on, while the context suggested it should read VehicleRegistrationService
  • dapr deserves a uppercase D ;-)

All other "Step" headers were at H2, only this one at H3
@mthmulders mthmulders changed the title Fix heading type WIP: Small changes in Assignment 2 (step-by-step) Jun 27, 2021
@mthmulders mthmulders changed the title WIP: Small changes in Assignment 2 (step-by-step) Small changes in Assignment 2 (step-by-step) Jun 27, 2021
@EdwinVW
Copy link
Owner

EdwinVW commented Jun 27, 2021

Thanks for these changes @mthmulders.

  • I believe the text referred to the wrong application: it read FineCollectionService, but that's the application where the students are working on, while the context suggested it should read VehicleRegistrationService

This should read "FineCollectionService" actually. You specify the values for how the FineCollectionService calls the VehicleRegistrationService. And these are:

  • 3601 : the port of the FineCollectionService's sidecar and
  • VehicleRegistrationService : the app-id of the service that should be called

@mthmulders
Copy link
Contributor Author

Thanks for these changes @mthmulders.

  • I believe the text referred to the wrong application: it read FineCollectionService, but that's the application where the students are working on, while the context suggested it should read VehicleRegistrationService

This should read "FineCollectionService" actually. You specify the values for how the FineCollectionService calls the VehicleRegistrationService. [...]:

What I understood (after a lot of studying and re-reading) is that the text refers to the configuration of the FineCollectionService as far as it describes the interaction with the VehicleRegistrationService. I think the difference is in how the both of us interpret "values for the XXX" - to you, XXX is the application who owns that value, whereas I understood it as "the target of XXX", or in other words "the location where the application that owns the value can find their XXX". Let me just say that it got me completely on the wrong track initially... ;-)

How about this?

You can substitute the placeholders in this URL for the FineCollectionService with the appropriate values describing the location of the VehicleRegistrationService, this yields the following URL:

@EdwinVW
Copy link
Owner

EdwinVW commented Jun 27, 2021

What I understood (after a lot of studying and re-reading) is that the text refers to the configuration of the FineCollectionService as far as it describes the interaction with the VehicleRegistrationService. I think the difference is in how the both of us interpret "values for the XXX" - to you, XXX is the application who owns that value, whereas I understood it as "the target of XXX", or in other words "the location where the application that owns the value can find their XXX". Let me just say that it got me completely on the wrong track initially... ;-)

How about this?

You can substitute the placeholders in this URL for the FineCollectionService with the appropriate values describing the location of the VehicleRegistrationService, this yields the following URL:

I understand the confusion! But it is actually not the location of the VehicleRegistrationService (VRS) you specify. That is also the point I'm trying to make in the note after this text. You specify the app-id of the VHS and the Dapr http port of the FineCollectionService. Let's try this:

You can substitute the placeholders in this URL with the appropriate values so the FineCollectionService's sidecar can call the the VehicleRegistrationService, this yields the following URL:

Does that make more sense?

@mthmulders
Copy link
Contributor Author

You specify the app-id of the VHS and the Dapr http port of the FineCollectionService.

Gotcha! The devil is - again - in the details.... I just didn't grasp that level of detail from the text. But the last suggestion works fine for me, I'll update the MR accordingly. Thanks for taking the time to consider it!

@EdwinVW
Copy link
Owner

EdwinVW commented Jun 27, 2021

Thanks for taking the time to consider it!

No problem. Thank you for challenging this!
The text should be clear. And if it's not, we should update it!

@EdwinVW EdwinVW merged commit e749931 into EdwinVW:main Jun 27, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Jul 7, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Jul 14, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Jul 14, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Jul 15, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Aug 18, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Aug 18, 2021
mthmulders added a commit to mthmulders/dapr-workshop that referenced this pull request Aug 24, 2021
EdwinVW added a commit that referenced this pull request Aug 29, 2021
* Prepare starting point for Java track

* Setup starting point for Traffic Service (Java track)

* Setup starting point for Simulator (Java track)

* Package as runnable JARs

* Setup starting point for Fine Calculation (Java track)

* Setup starting point for Vehicle Registration (Java track)

* Align vocabulary over services

* Write assignment 1 for Java

* Fix spelling of cURL

* Ignore project files from VS Code

* Add work-around for conflicting versions of OkHttp

Spring Boot ships a 3.x version of Okhttp but Dapr
requires 4.x
see dapr/java-sdk#515

* Delombok

* Write assignment 2 for Java

* Update after #6

* Specify addresses in simpler format

* Serialise timestamps in RestTemplate requests in ISO format

* Manage version of Spring Boot integration

* Write assignment 3 for Java

* Prepare infrastructure scripts

* Update dependency versions

* Write assignment 4 for Java

* Write assignment 5 for Java

* Setup starting point for Simulator (Java track)

* Cars have a license number for legal purposes

Thanks for pointing that out, @EdwinVW

* Add src-java folder to DIY instructions

* Write assignment 6 for Java

* Write assignment 7 for Java

* CRITICAL: Add missing param to call.

The params were not added to the call, leading to a failure when you execute the getVehicleInfo()

* Remove unused property

The FineCollectionService does not need a property towards it's own endpoint. This seems to be a CopyPasta from the TrafficControlService.

* Textual improvements as suggested by @TomCools

* Add requirements for the Java track

* Rename 'src' folder to 'dotnet'

* Rename 'src-java' folder to 'java'

* Move all infrastructure scripts to one folder

* Use the RabbitMQ image with management interface

* Add .NET and Java introduction to global README

* Fix text in links to instructions for 'for Java'

* Minor textual updates

Co-authored-by: Tom Cools <tom.cools@live.be>
Co-authored-by: EdwinVW <edwinvw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants