Skip to content

Commit

Permalink
(deps/fix/types): upgrade rollup & fix event type issues (jaredpalmer…
Browse files Browse the repository at this point in the history
…#544)

- if TSDX were installed directly from git, the `prepare` script would
  for some reason fail on these events
  - but they wouldn't error when run internally
    - when Rollup was upgraded, then they started erroring

- also remove the unnecessary await in front of watch
  • Loading branch information
agilgur5 authored and paul-vd committed Dec 1, 2020
1 parent 370d0f9 commit f5cfbc6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"pascal-case": "^2.0.1",
"prettier": "^1.19.1",
"progress-estimator": "^0.2.2",
"rollup": "^1.27.8",
"rollup": "^1.32.1",
"rollup-plugin-babel": "^4.3.2",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.2",
Expand Down
7 changes: 1 addition & 6 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ prog
}

const spinner = ora().start();
await watch(
watch(
(buildConfigs as RollupWatchOptions[]).map(inputOptions => ({
watch: {
silent: true,
Expand All @@ -385,11 +385,6 @@ prog
logError(event.error);
failureKiller = run(opts.onFailure);
}
if (event.code === 'FATAL') {
spinner.fail(chalk.bold.red('Failed to compile'));
logError(event.error);
failureKiller = run(opts.onFailure);
}
if (event.code === 'END') {
spinner.succeed(chalk.bold.green('Compiled successfully'));
console.log(`
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5656,10 +5656,10 @@ rollup@^0.63.4:
"@types/estree" "0.0.39"
"@types/node" "*"

rollup@^1.27.8:
version "1.27.8"
resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.27.8.tgz#94288a957af9f4c2380b73a17494d87705997d0f"
integrity sha512-EVoEV5rAWl+5clnGznt1KY8PeVkzVQh/R0d2s3gHEkN7gfoyC4JmvIVuCtPbYE8NM5Ep/g+nAmvKXBjzaqTsHA==
rollup@^1.32.1:
version "1.32.1"
resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.32.1.tgz#4480e52d9d9e2ae4b46ba0d9ddeaf3163940f9c4"
integrity sha512-/2HA0Ec70TvQnXdzynFffkjA6XN+1e2pEv/uKS5Ulca40g2L7KuOE3riasHoNVHOsFD5KKZgDsMk1CP3Tw9s+A==
dependencies:
"@types/estree" "*"
"@types/node" "*"
Expand Down

0 comments on commit f5cfbc6

Please sign in to comment.