Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack build output in dist folder #1609

Merged
merged 4 commits into from
Nov 6, 2023
Merged

pack build output in dist folder #1609

merged 4 commits into from
Nov 6, 2023

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Nov 6, 2023

This re-introduces the packaging step to our build pipeline.

It also fixes the ts-node regression.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f82b470

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fubhy fubhy marked this pull request as draft November 6, 2023 21:21
@fubhy
Copy link
Member Author

fubhy commented Nov 6, 2023

Blocked on Effect-TS/build-utils#27

@fubhy fubhy requested a review from tim-smart November 6, 2023 21:21
@fubhy fubhy marked this pull request as ready for review November 6, 2023 21:29
@fubhy fubhy merged commit d676bb0 into main Nov 6, 2023
@fubhy fubhy deleted the build-pack branch November 6, 2023 21:57
patroza added a commit that referenced this pull request Nov 7, 2023
@patroza
Revert "pack build output in dist folder (#1609)"
684b74b 
This reverts commit d676bb0.
patroza added a commit that referenced this pull request Nov 8, 2023
@patroza
Revert "pack build output in dist folder (#1609)"
a12edbb 
This reverts commit d676bb0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IMax153 IMax153 IMax153 approved these changes

@tim-smart tim-smart Awaiting requested review from tim-smart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fubhy @IMax153