Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule: fix unsafe tapOutput signature #4439

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

gcanti
Copy link
Contributor

@gcanti gcanti commented Feb 11, 2025

Previously, tapOutput allowed using an output type that wasn't properly inferred, leading to potential runtime errors. Now, TypeScript correctly detects mismatches at compile time, preventing unexpected crashes.

Before (Unsafe, Causes Runtime Error)

import { Effect, Schedule, Console } from "effect"

const schedule = Schedule.once.pipe(
  Schedule.as<number | string>(1),
  Schedule.tapOutput((s: string) => Console.log(s.trim())) // ❌ Runtime error
)

Effect.runPromise(Effect.void.pipe(Effect.schedule(schedule)))
// throws: TypeError: s.trim is not a function

After (Safe, Catches Type Error at Compile Time)

import { Console, Schedule } from "effect"

const schedule = Schedule.once.pipe(
  Schedule.as<number | string>(1),
  // ✅ Type Error: Type 'number' is not assignable to type 'string'
  Schedule.tapOutput((s: string) => Console.log(s.trim()))
)

@gcanti gcanti added the bug Something isn't working label Feb 11, 2025
@gcanti gcanti requested a review from mikearnaldi as a code owner February 11, 2025 17:21
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: b812a79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/ai Patch
@effect/ai-openai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gcanti gcanti merged commit 543d36d into main Feb 11, 2025
12 checks passed
@gcanti gcanti deleted the fix-schedule-tapOutput branch February 11, 2025 17:29
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant