Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README example #11

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

joshamaju
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

The DevTools library can't communicate with the vscode extension when used with Node versions that don't support the Websocket API. Include a note in the documentation so that users can switch to a supported Node version or provide their own implementation.

Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 88a6993

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
effect-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart
Copy link
Member

@joshamaju
Copy link
Contributor Author

joshamaju commented Jul 13, 2024

Should I also document that?

@tim-smart tim-smart changed the title Document minimum required node version Update README example Jul 16, 2024
@tim-smart tim-smart merged commit ac416cd into Effect-TS:main Jul 16, 2024
@tim-smart tim-smart mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants