Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EgorBot for AaronRobinsonMSFT in #107218 #61

Open
EgorBot opened this issue Sep 3, 2024 · 5 comments
Open

EgorBot for AaronRobinsonMSFT in #107218 #61

EgorBot opened this issue Sep 3, 2024 · 5 comments

Comments

@EgorBot
Copy link
Owner

EgorBot commented Sep 3, 2024

Processing dotnet/runtime#107218 (comment) command:

Command

-intel -arm64 -perf

using System;
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

BenchmarkRunner.Run<Bench>(args: args);

public class Bench
{
    [Benchmark]
    public void Foo()
    {
        for (int i = 0; i < 1000; i++)
            Work<char>(1);
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    static void Work<T>(int size) => GC.KeepAlive(GC.AllocateUninitializedArray<T>(size));
}

(EgorBot will reply in this issue)

@EgorBot
Copy link
Owner Author

EgorBot commented Sep 3, 2024

Benchmark results on Intel

BenchmarkDotNet v0.14.0, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 8 logical and 4 physical cores
  Job-QZYBNP : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-BSZHLM : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
Method Toolchain Mean Error Ratio
Foo Main 9.324 μs 0.1835 μs 1.00
Foo PR 8.896 μs 0.1191 μs 0.95

BDN_Artifacts.zip

Flame graphs: Main vs PR 🔥
Hot asm: Main vs PR
Hot functions: Main vs PR
Counters: Main vs PR

For clean perf results, make sure you have just one [Benchmark] in your app.

@EgorBot
Copy link
Owner Author

EgorBot commented Sep 3, 2024

cc @AaronRobinsonMSFT (logs)

@EgorBot
Copy link
Owner Author

EgorBot commented Sep 3, 2024

Benchmark results on Ampere

BenchmarkDotNet v0.14.0, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Ampere
  Job-NAIHYY : .NET 10.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
  Job-XKUARV : .NET 10.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
RatioSD=0.02
Method Toolchain Mean Error Ratio
Foo Main 9.827 μs 0.1672 μs 1.00
Foo PR 9.251 μs 0.1111 μs 0.94

BDN_Artifacts.zip

Flame graphs: Main vs PR 🔥
Hot asm: Main vs PR
Hot functions: Main vs PR
Counters: Main vs PR

For clean perf results, make sure you have just one [Benchmark] in your app.

@EgorBot
Copy link
Owner Author

EgorBot commented Sep 3, 2024

cc @AaronRobinsonMSFT (logs)

@EgorBo
Copy link

EgorBo commented Sep 3, 2024

Looks like I broke profiler mode in my recent updates to the bot 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants