-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helper Method Frames for Exception, GC and Thread methods #107218
Conversation
Tagging subscribers to this area: @mangod9 |
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
The trimming tests are failing with |
This comment was marked as resolved.
This comment was marked as resolved.
@EgorBot -intel -arm64 -perf
|
- GC.AllocateNewArray()
@EgorBot -intel -arm64 -perf
|
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
@jkotas All green. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…net#107218) * Convert Exception.GetFrozenStackTrace() * Convert GC.AllocateNewArray() Removed use of Unsafe.As(). * Convert Thread.GetApartmentStateNative() and Thread.SetApartmentStateNative() * Convert Thread.Join() * Convert Thread.Priority property
…net#107218) * Convert Exception.GetFrozenStackTrace() * Convert GC.AllocateNewArray() Removed use of Unsafe.As(). * Convert Thread.GetApartmentStateNative() and Thread.SetApartmentStateNative() * Convert Thread.Join() * Convert Thread.Priority property
Each commit contains a single or pair of functions. This PR is best reviewed by each commit.