Added tests for severity

[Hekku2]

• Added tests for related items
• Fixed broken tests
• Fixed jshint-warnings
• Fixed case where observable with severity-function defined causes errors. This can happen when for example 'equal'-rule is used and it refers to validatable observable.

[egucciar]

It seems like all of the use cases of severity were covered by your tests.

However I did notice you added an extra conditional check to ensure params being passed to KO validation is not observable. Is this needed?

There are cases where I am passing observables to KO validation for custom rules I have created in order to do more complex validations which require reacting to changes in params. Let me know if you can resubmit the pull request without this check, and if so I will merge it.

[Hekku2]

That indeed breaks that.

The problem that rises is that now 'validatable' observables can't be directly used as parameters, because they now have the 'severity'-function added by this feature. I belive this breaks current functionality.

Perhaps the severity-function in validatable should be renamed to something different, like 'errorSeverity' or something?

See commit for suggestion.

[egucciar]

due to the fact we are using this lib in many places already I am hesitant to introduce a breaking change to our code.

Let's think of this from another perspective, in your first commit you disregard all params which are observables, that didn't work for my use case, but I don't have a usecase where I actually require params to be a validated observable. Why not check if the severity property is observable and return only then? That way both our usecases get satisfied without having to introduce breaking API changes within the code.

params && !ko.isObservable(params.severity)

[Hekku2]

That sounds fine.

[egucciar]

Let me know once the commits are made.

[Hekku2]

Now it should not break existing code, hoping that someone doesn't use severity observable with parameters.

[egucciar]

I agree, I will have to think about how we should be handling that down the line, but for now this is great. thanks for your contribution.