#14 introducing a new telemetry struct

pkg/cmd/cli.go

@@ -3,8 +3,6 @@ package cmd
 import (
 	"github.com/spf13/cobra"
 	"glide/pkg"
-	"glide/pkg/telemetry"
-	"go.uber.org/zap"
 )
 
 // NewCLI Create a Glide CLI
@@ -14,18 +12,6 @@ func NewCLI() *cobra.Command {
 		Use:     "",
 		Version: pkg.GetVersion(),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			// TODO: gonna be read from a config file
-			logConfig := telemetry.NewLogConfig()
-			logConfig.Level = zap.NewAtomicLevelAt(zap.DebugLevel)
-			logConfig.Encoding = "console"
-			logger, err := telemetry.NewLogger(logConfig)
-
-			if err != nil {
-				return err
-			}
-
-			logger.Debug("logger inited")
-
 			gateway, err := pkg.NewGateway()
 
 			if err != nil {

pkg/gateway.go

@@ -5,7 +5,9 @@ import (
 	"fmt"
 	"glide/pkg/api"
 	"glide/pkg/api/http"
+	"glide/pkg/telemetry"
 	"go.uber.org/multierr"
+	"go.uber.org/zap"
 	"os"
 	"os/signal"
 	"syscall"
@@ -23,13 +25,25 @@ type Gateway struct {
 }
 
 func NewGateway() (*Gateway, error) {
+	// TODO: gonna be read from a config file
+	logConfig := telemetry.NewLogConfig()
+	logConfig.Level = zap.NewAtomicLevelAt(zap.DebugLevel)
+	logConfig.Encoding = "console"
+
+	logger, err := telemetry.NewLogger(logConfig)
+
+	if err != nil {
+		return nil, err
+	}
+
 	serverManager, err := api.NewServerManager(&http.HTTPServerConfig{})
 
 	if err != nil {
 		return nil, err
 	}
 
 	return &Gateway{
+		logger:        logger,
 		serverManager: serverManager,
 		signalC:       make(chan os.Signal, 3), // equal to number of signal types we expect to receive
 		shutdownC:     make(chan struct{}),

pkg/telemetry/telemetry.go

@@ -0,0 +1,34 @@
+package telemetry
+
+import "go.uber.org/zap"
+
+type TelemetryConfig struct {
+	LogConfig *LogConfig `json:"logs" yaml:"logs"`
+	// TODO: add OTEL config
+}
+
+type Telemetry struct {
+	logger *zap.Logger
+	// TODO: add OTEL meter, tracer
+}
+
+func NewTelemetry(cfg *TelemetryConfig) (*Telemetry, error) {
+	// TODO: gonna be read from a config file
+	logConfig := NewLogConfig()
+	logConfig.Level = zap.NewAtomicLevelAt(zap.DebugLevel)
+	logConfig.Encoding = "console"
+
+	logger, err := telemetry.NewLogger(logConfig)
+
+	if err != nil {
+		return nil, err
+	}
+
+	return &Telemetry{
+		logger: logger,
+	}
+}
+
+func (t *Telemetry) Logger() *zap.Logger {
+	return t.logger
+}