Feature/3 provider openai #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roma-glushko
approved these changes
Dec 10, 2023
go.sum
Outdated
| @@ -0,0 +1,2 @@ | |||
| github.com/joho/godotenv v1.5.1 h1:7eLL/+HRGLY0ldzfGMeQkb7vMd0as4CfYvUVzLqw0N0= | |||
There was a problem hiding this comment.
Do we want to install it temporarily until we have #11 done?
For that, you need to do go get ... again and make sure go.mod is updated as well
There was a problem hiding this comment.
I removed the dependency as it wasn't being used.
| FunctionCall: ConfigItem{ | ||
| Param: "function_call", | ||
| }, | ||
| MaxTokens: NumericConfigItem{ |
There was a problem hiding this comment.
Would be good to investigate if there any Pydantic-like validation in Golang, so these basic validations are done for us out-of-the-box.
There was a problem hiding this comment.
I'll explore this
| @@ -0,0 +1,119 @@ | |||
| package openai | |||
|
|
|||
| type ProviderConfig struct { | |||
There was a problem hiding this comment.
Wondering what part of these wide variety of configs should be passed in realtime and what would be set up in the service config
There was a problem hiding this comment.
Moved this convo to Discord
roma-glushko
added a commit
that referenced
this pull request
Dec 10, 2023
mkrueger12
pushed a commit
that referenced
this pull request
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open api chat endpoint schema & general api schema