Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error #236

Merged
merged 12 commits into from
May 12, 2024

#235: Updated the example in the readme

78f70ef
Select commit
Loading
Failed to load commit list.
Merged

🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error #236

#235: Updated the example in the readme
78f70ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2024 in 1s

67.09% (-0.15%) compared to 3b37d0b

View this Pull Request on Codecov

67.09% (-0.15%) compared to 3b37d0b

Details

Codecov Report

Attention: Patch coverage is 28.57143% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 67.09%. Comparing base (3b37d0b) to head (78f70ef).

Files Patch % Lines
pkg/api/schemas/errors.go 10.52% 17 Missing ⚠️
pkg/api/http/handlers.go 0.00% 16 Missing ⚠️
pkg/routers/router.go 50.00% 3 Missing and 1 partial ⚠️
pkg/providers/cohere/finish_reason.go 25.00% 3 Missing ⚠️
pkg/providers/openai/finish_reasons.go 25.00% 3 Missing ⚠️
pkg/providers/bedrock/chat.go 0.00% 1 Missing ⚠️
pkg/routers/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
- Coverage    67.24%   67.09%   -0.15%     
===========================================
  Files           78       79       +1     
  Lines         3633     3644      +11     
===========================================
+ Hits          2443     2445       +2     
- Misses        1061     1070       +9     
  Partials       129      129              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.