#72: Update AzureOAI client #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making compatible with resilience router |
roma-glushko
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
@mkrueger12 could you please also account for the provider in the following validation method: https://github.com/EinStack/glide/blob/develop/pkg/providers/config.go#L49-L70
|
Thank you for keeping the PR green ❤️ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #73 +/- ##
===========================================
- Coverage 64.53% 63.87% -0.66%
===========================================
Files 25 27 +2
Lines 1108 1182 +74
===========================================
+ Hits 715 755 +40
- Misses 348 381 +33
- Partials 45 46 +1 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.