Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some sequences not printing in titles/filenames #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lefth
Copy link

@lefth lefth commented Jul 17, 2022

This fixes issue #51: for example "temp\home" is shown as "temp ome".

@dyphire
Copy link
Contributor

dyphire commented Jul 17, 2022

I think the better change is:

p = p:gsub("\\", "/")
     :gsub("{", "\\{")
     :gsub("^ ", "\\h")

This will unify the display of path format.
And this change also should be applied to the other two scripts: SimpleBookmark.lua, SmartCopyPaste_II.lua.

This fixes issue Eisa01#51: for example "temp\home" is shown as "temp ome".
@lefth
Copy link
Author

lefth commented Jul 18, 2022

Done.

Though I don't like changing the path separator, the code is short this way, and that's ideal because writing lua modules or shared functions for recent versions of mpv is tricky.

@Eisa01
Copy link
Owner

Eisa01 commented Oct 21, 2022

I believe I have written a function that deals with escape sequences, because there is multiple escape_sequences not dealt with in this PR. I must have forgot to call the existing method on this list.

@Eisa01
Copy link
Owner

Eisa01 commented Oct 21, 2022

I will keep this open for reference until changes are made to fix issue #51

Eisa01 added a commit that referenced this pull request Nov 18, 2022
Well, this is basically 1.3.0 beta. Too many improvements and backend changes. 
Users are required to update their conf file.

Changes:
added option to parse items list so that we can modify it however we want with tons of variables, e.g.: %number%. %name% instead of only modifying through pre-defined options
added option to create and define variables for parse_list and parse_header
added option to show date in the the list using any format as per lua documentation. targetting #50
added 'local' option for file_title_logging and made 'all' as the default since we can utilize the file title better now thanks to parsing list items
added backward compatibility for reading the log file for dates that cannot be parsed and improved error handling. closes #58
improved search_behavior to support parsed dates and groups
improved read_log_table so that now the title and the name are always presented correctly
fixed list not displaying properly when path or name include special characters using a new function closes #51 and #52
removed most list settings that are no longer relevant because user can parse our own list now
removed the option customize the date logging method and made a fixed format (YYYY-MM-DDT00:00:00) similar to ISO8601 that could be parsed by the script
removed 'specific' search_behavior since the improved any search is way better
removed prefer_filename_over_title "doesnt seem useful now since we can parse the text and show title whenever we want"
trimmed down useless settings and some unnecessary variables and options
some other bug fixes and hopefully didn't create new bugs o_o
updated description of config to reflect the new changes
@Eisa01
Copy link
Owner

Eisa01 commented Nov 18, 2022

Only remaining is to migrate the changes of 2044e43 to SimpleHistory, and SmartCopyPaste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants