Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a parameter to control the sort order of dependencies in dependency management. #214

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Add a parameter to control the sort order of dependencies in dependency management. #214

merged 1 commit into from
Jul 7, 2022

Conversation

ssquan
Copy link
Contributor

@ssquan ssquan commented May 30, 2022

Issues: #210

@ssquan ssquan requested a review from Ekryd as a code owner May 30, 2022 15:27
@Ekryd
Copy link
Owner

Ekryd commented Jun 2, 2022

Nice!! You can follow sortDependencies and sortDependencyExclusions to look for which tests they are involved in

@Ekryd Ekryd changed the base branch from master to issue-210-Suggestion_Add_a_parameter_to_control_the_sort_of_dependencies_in_dependencymanagement June 2, 2022 18:22
@ssquan ssquan force-pushed the master branch 2 times, most recently from 12c83f3 to d1c56a9 Compare June 12, 2022 08:56
@ssquan ssquan changed the title [WIP] Add a parameter to control the sort order of dependencies in dependency management. Add a parameter to control the sort order of dependencies in dependency management. Jun 12, 2022
@ssquan ssquan requested a review from Ekryd June 12, 2022 08:58
@Ekryd
Copy link
Owner

Ekryd commented Jun 18, 2022

Hi! I have some busy days ahead right now, but hope to review this soon. Thanks for your contribution

@ssquan
Copy link
Contributor Author

ssquan commented Jun 21, 2022

Hi! I have some busy days ahead right now, but hope to review this soon. Thanks for your contribution
Never mind.

@Ekryd Ekryd merged commit 1614574 into Ekryd:issue-210-Suggestion_Add_a_parameter_to_control_the_sort_of_dependencies_in_dependencymanagement Jul 7, 2022
@Ekryd
Copy link
Owner

Ekryd commented Jul 7, 2022

Now I am back from some extended leave

@Ekryd
Copy link
Owner

Ekryd commented Jul 7, 2022

This code would need an integration test (under maven-plugin/src/it) that ensures that the order for dependency management and dependencies can be set independently

@Ekryd
Copy link
Owner

Ekryd commented Jul 7, 2022

I added a test for verifying that the parameter is properly propagated to elementWrapperCreator and also merged in the latest changes from master. I am using the branch issue-210-Suggestion_Add_a_parameter_to_control_the_sort_of_dependencies_in_dependencymanagement

@Ekryd
Copy link
Owner

Ekryd commented Jul 7, 2022

I just discovered that the description of the scope order is incorrect. IMPORT is ranked first, I will fix that in master and update the 210 branch with the change

@Ekryd
Copy link
Owner

Ekryd commented Jul 7, 2022

Added a test where dependency management sorting is disabled while normal dependencies still are sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekryd Ekryd Ekryd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssquan @Ekryd