-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to run benchmarks #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno Left some comments!
does the current rosbag provide a groundtruth topic?
I didn't record an extra topic for ground truth since odom-to-base_link is the ground truth in the perfect_odometry bagfile, but +1 to having ground truth in bagfiles. Note that for this case, in evo you can compare odom-to-base_link and map-to-base_link.
Lol, I didn't pay attention to the name of the bag haha. |
I tried to make some progress on this. It seems that the easy solution is to use a bag with a ground truth topic (or check how to add tf support to evo). |
maybe we can use the Odometry message |
Yes, I think that's the easier thing to do, I will record a new bag that includes the odometry topic. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
1183461
to
7343ed3
Compare
Results: The folder benchmark was compiled in I'm failing to generate results for nav2_amcl, for some reason it's segfaulting now ...... To see the timem results, use: /ws/src/scripts/benchmarking/timem_metrics_results /path/to/folder/with/timem/json/output To get ape metrics: evo_ape bag2 benchmark_1000_particles_output/rosbag/ /odometry/ground_truth /pose |
The issue I'm running into is ros-navigation/navigation2#3311. |
I was finally able to record the same cases for nav2 (it doesn't seem to fail if commenting out the (edit: uploaded new zip, as I forgot to record the /amcl_pose topic) |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@gmail.com>
I run both again with some changes:
I'm working in an script to easily compare both results |
* Add script to plot results comparision. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@gmail.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@gmail.com>
Not for a comparison, but I wonder why the APE maximum is consistently higher for |
Yes, I guessed it was that. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Remove .sh extension from executable scripts. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
I see that's already provided by evo, see 1a50027. The maximum APE error seems to happen just before the bagfile ends (i.e. before shutdown). It happens pretty consistently for |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno I have only minor comments.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Nahuel Espinosa <nespinosa@ekumenlabs.com> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Nahuel Espinosa <nespinosa@ekumenlabs.com> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Nahuel Espinosa <nespinosa@ekumenlabs.com> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Nahuel Espinosa <nespinosa@ekumenlabs.com> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno LGTM!
Related to #35. Adds a script that allows running a rosbag repeatedly, configuring amcl with different number of particles. It records another bagfile with the result, the results of timem, and optionally perf events data. It also adds postprocessing scripts, and instructions of how to run them. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Related to #35.
Summary
Adds a script that allows running a rosbag repeatedly, configuring amcl with different number of particles.
It records another bagfile with the result, the results of timem, and optionally perf events data.
The missing thing is the postprocessing steps.
qq: does the current rosbag provide a groundtruth topic?
We will need that to use something a tool like
evo
.Checklist