Extend development containers #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ROS 2 Rolling container - Add tooling to ease debugging Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Opening this for visibility. OK with dropping it if misleading (given CI supports targets Humble). |
nahueespinosa
approved these changes
May 5, 2023
There is a reason not to do that. Build procedures are not exactly equivalent, and conditional statements are not a thing in Dockerfiles. Also, as time goes by, the Rolling container will become increasingly distinct from those for earlier LTS releases. At the current LOC count, I'm personally comfortable with the duplication (doesn't mean you have to be). If it gets out of hand, we can put common statements in scripts. |
nahueespinosa
approved these changes
May 5, 2023
glpuga
pushed a commit
that referenced
this pull request
May 10, 2023
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
glpuga
pushed a commit
that referenced
this pull request
May 10, 2023
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
glpuga
pushed a commit
that referenced
this pull request
May 10, 2023
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
7 tasks
hidmic
added a commit
that referenced
this pull request
Sep 30, 2024
### Proposed changes Follow-up to #173. Hopefully this time around we get multi-platform development containers right. #### Type of change - [x] 🐛 Bugfix (change which fixes an issue) - [ ] 🚀 Feature (change which adds functionality) - [ ] 📚 Documentation (change which fixes or extends documentation) ### Checklist - [ ] Lint and unit tests (if any) pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excerpt from #168.
Summary
This patch allows for both ROS 2 Humble and ROS 2 Rolling development containers, the latter particularly useful to compare against
nav2_amcl, partially broken on Humble (see ros-navigation/navigation2#3311). It also adds tooling to ease debugging.Checklist