Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert perfect_odometry bagfile changes #235

Closed
wants to merge 1 commit into from
Closed

Revert perfect_odometry bagfile changes #235

wants to merge 1 commit into from

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Jun 25, 2023 •
edited
Loading

Proposed changes

Fixes #232.

  • Re-add the /clock topic to the ROS bag.
  • Remove the --clock argument from the ros2 bag play command.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa
Revert perfect_odometry bag changes
6a80a36 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added the bug Something isn't working label Jun 25, 2023
@nahueespinosa nahueespinosa self-assigned this Jun 25, 2023
hidmic
hidmic reviewed Jun 28, 2023
View reviewed changes
beluga_example/bags/perfect_odometry/metadata.yaml
topics_with_message_count:
- topic_metadata:
name: /clock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nahueespinosa meta: it's OK to have a /clock topic, but it shouldn't be necessary, rosbag2 can be instructed to publish it.

@nahueespinosa
Copy link
Member Author

Closing this one, I'll push another PR with an actual fix.

@nahueespinosa nahueespinosa deleted the nahuel/revert-rosbag-changes branch July 1, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

Assignees

@nahueespinosa nahueespinosa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeline mixup when running bagfile
2 participants
@nahueespinosa @hidmic