Rewrite take_evenly view #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueespinosa
commented
Oct 7, 2024
nahueespinosa
force-pushed
the
nahuel/rewrite-take-evenly
branch
2 times, most recently
from
0b9fdf5 to
9ad988f
Compare
Avoids using a range pipeline to implement the take_evenly view which is not great for compile times. This implementation also makes it a random access view when the underlying range is random access. Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
force-pushed
the
nahuel/rewrite-take-evenly
branch
from
9ad988f to
7f00c10
Compare
hidmic
reviewed
Oct 7, 2024
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Avoids using a range pipeline to implement the take_evenly view which is not great for compile times.
This implementation also makes it a random access view when the underlying range is random access.
Type of change
Checklist