Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pathlib instead of string formatting #249

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

rnestler
Copy link
Contributor

@rnestler rnestler commented Apr 7, 2022

Using pathlib.Path should be more robust than concatenating strings
together.

Using pathlib.Path should be more robust than concatenating strings
together.
@ElSnoMan ElSnoMan added the enhancement New feature or request label Apr 7, 2022
@ElSnoMan
Copy link
Owner

ElSnoMan commented Apr 7, 2022

Another great addition! Thanks for the improvements 💪🏽

@ElSnoMan ElSnoMan merged commit d328246 into ElSnoMan:main Apr 7, 2022
@rnestler rnestler deleted the use-pathlib-path branch April 8, 2022 06:36
@rnestler
Copy link
Contributor Author

rnestler commented Apr 8, 2022

It looks like you accidentally reverted my changes from #247 when merging this pull request?

@ElSnoMan
Copy link
Owner

ElSnoMan commented Apr 8, 2022

It was an accident. I was using GitHub's UI to resolve conflicts and then the page froze. I thought it kept your changes but apparently it didn't. Hence the rush on 1.15.3

@rnestler
Copy link
Contributor Author

rnestler commented Apr 8, 2022

Ah and you re-added it back in #250, I somehow missed that. Well no harm apart of a bit of a strange git history and me being a bit confused 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants