Use pathlib instead of string formatting #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using pathlib.Path should be more robust than concatenating strings together.
ElSnoMan
approved these changes
Apr 7, 2022
|
Another great addition! Thanks for the improvements 💪🏽 |
|
It looks like you accidentally reverted my changes from #247 when merging this pull request? |
|
It was an accident. I was using GitHub's UI to resolve conflicts and then the page froze. I thought it kept your changes but apparently it didn't. Hence the rush on |
|
Ah and you re-added it back in #250, I somehow missed that. Well no harm apart of a bit of a strange git history and me being a bit confused 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pathlib.Path should be more robust than concatenating strings
together.