Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint fixes #288

Merged
merged 3 commits into from
Oct 21, 2022
Merged

pylint fixes #288

merged 3 commits into from
Oct 21, 2022

Conversation

marksmayo
Copy link
Contributor

Simplifying some statements / code blocks, fixing deprecated logging calls, and a couple of others.

Simplifying some statements / code blocks, fixing deprecated logging calls, and a couple of others.
Copy link
Owner

@ElSnoMan ElSnoMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning things up and submitting a Pull Request! I have one small request, but otherwise, it all looks great! I just merged a branch to main, which you'll probably want to merge to this branch, but hopefully there are no conflicts

@ElSnoMan ElSnoMan added the chore Miscellaneous tasks for the repo/project label Oct 20, 2022
@marksmayo
Copy link
Contributor Author

@ElSnoMan looks like your merge broke one test? test_element_actions.py, seems unable to find a file?

@ElSnoMan ElSnoMan merged commit 40eb9b6 into ElSnoMan:main Oct 21, 2022
@ElSnoMan
Copy link
Owner

@ElSnoMan looks like your merge broke one test? test_element_actions.py, seems unable to find a file?

It's been resolved, so no worries. Your PR has been merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous tasks for the repo/project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants