Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install another flake8 version in CI #300

Merged

Conversation

rnestler
Copy link
Contributor

@rnestler rnestler commented Jun 6, 2023

flake8 is already specified as a dev-dependency in pyproject.toml, so adding it to the project will result in requiring two conflicting flake8 versions: The one specified in pyproject.toml and the latest one.

flake8 is already specified as a dev-dependency in pyproject.toml, so
adding it to the project will result in requiring two conflicting flake8
versions: The one specified in pyproject.toml and the latest one.
@rnestler
Copy link
Contributor Author

rnestler commented Jun 6, 2023

The install and linting step passes now, but the unit tests fail...

@ElSnoMan
Copy link
Owner

I'll approve and merge for now since this is a simple fix. Thanks for doing this!

@ElSnoMan ElSnoMan merged commit 17110df into ElSnoMan:main Jun 14, 2023
@rnestler rnestler deleted the do-not-install-another-flake8-version-in-ci branch June 15, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants