Do not install another flake8 version in CI #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 is already specified as a dev-dependency in pyproject.toml, so adding it to the project will result in requiring two conflicting flake8 versions: The one specified in pyproject.toml and the latest one.
|
The install and linting step passes now, but the unit tests fail... |
|
I'll approve and merge for now since this is a simple fix. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 is already specified as a dev-dependency in pyproject.toml, so adding it to the project will result in requiring two conflicting flake8 versions: The one specified in pyproject.toml and the latest one.