Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ updating dependencies #305

Merged
merged 1 commit into from
Jun 21, 2023
Merged

⬆️ updating dependencies #305

merged 1 commit into from
Jun 21, 2023

Conversation

LostInDarkMath
Copy link
Contributor

Hi there,
apparently your dependencies are completely out of date and your bot seems to catch only a fraction as well: #303

Therefore I have updated them quickly. Would be cool if you could merge this in a timely manner.

Keep in mind: There are breaking changes. Instead of Python >= 3.7 now Python >= 3.8.1 is required.

@ElSnoMan
Copy link
Owner

Hi @LostInDarkMath! Thanks for creating a PR 👏🏽

  • Many of the packages have been pinned because there were conflicts between some of them. If the newer versions no longer have these issues, then it makes total sense to update them!
  • dependabot, from GitHub, doesn't auto-update all packages. It looks for vulnerabilities in packages and then updates to the version that has fixes for them. In this case, requests reported some security updates in their latest release which triggered the dependabot scan and PR

ElSnoMan
ElSnoMan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Owner

@ElSnoMan ElSnoMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on multiple python versions and it worked! Great job 🎉

@ElSnoMan ElSnoMan added the chore Miscellaneous tasks for the repo/project label Jun 21, 2023
@ElSnoMan ElSnoMan merged commit 8f7d889 into ElSnoMan:main Jun 21, 2023
rnestler
rnestler reviewed Jun 21, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnestler rnestler rnestler left review comments

@ElSnoMan ElSnoMan ElSnoMan approved these changes

Assignees
No one assigned
Labels
chore Miscellaneous tasks for the repo/project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LostInDarkMath @ElSnoMan @rnestler