Add support for more jtagmkii baud rates #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem. I was sloppy reviewing. |
Can't believe how this slipped though...
|
All right, have you compiled and tested some of the new speeds? |
|
Only 230400 baud, because MacOS doesn't support arbitrary baud rates and baud rates higher than 230400. |
|
Ok, I think it suffices that one of the speeds works, just to make sure there is no misalignment in the data structures. edit: anyway, that's the main reason why it's better to support more speeds, I didn't new about that limitation of MacOS, but some serial/USB adapters do have some quirks and prefer certain speeds. |
ElTangas
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the typo in PR #55. Can't believe this slipped though...