Fixes a concurrency issue when working with versions => dotnet/corefx…

…#28225
Elders · Mar 21, 2019 · 38f9e29 · 38f9e29
1 parent 0c9328e
commit 38f9e29
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/Elders.Cronus/Projections/Versioning/InMemoryProjectionVersionStore.cs b/src/Elders.Cronus/Projections/Versioning/InMemoryProjectionVersionStore.cs
@@ -16,15 +16,18 @@ public ProjectionVersions Get(string projectionName)
         {
             if (string.IsNullOrEmpty(projectionName)) throw new ArgumentNullException(nameof(projectionName));
 
-            var versions = store.GetOrAdd(projectionName, new ProjectionVersions());
-            return versions;
+            return store.GetOrAdd(projectionName, new ProjectionVersions());
         }
 
         public void Cache(ProjectionVersion version)
         {
-            if (ReferenceEquals(null, version)) throw new ArgumentNullException(nameof(version));
-            var versions = store.GetOrAdd(version.ProjectionName, new ProjectionVersions());
-            versions.Add(version);
+            if (version is null) throw new ArgumentNullException(nameof(version));
+
+            ProjectionVersions versions = Get(version.ProjectionName);
+            lock (versions)
+            {
+                versions.Add(version);
+            }
         }
     }
 }