Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard crash if the client forcefully disconnects #1

Open
quinton-erasmus opened this issue Apr 18, 2019 · 1 comment
Open

Hard crash if the client forcefully disconnects #1

quinton-erasmus opened this issue Apr 18, 2019 · 1 comment

Comments

@quinton-erasmus
Copy link

Hi,

Maybe I was doing this wrong, but after a successful connection I close the client without closing the connection gracefully. In this case the server crashes and no try catch around the instantiation code helps the situation.

I will send a pull request now and hopefully that will better explain what I mean.

Thanks for the library!

quinton-erasmus added a commit to quinton-erasmus/SimpleWebSocketServer that referenced this issue Apr 18, 2019
Signed-off-by: Quinton Erasmus <quinton.erasmus@fortblox.io>
@zevero
Copy link

zevero commented Jul 31, 2019

I am using SimpleWebSocketServer as well and run into the same issue. Thank you for fixing. Unfortunately it is not in the nu-get package Version 1.1.0.

Please @EldinZenderink could you include the fix in the next Version?

Great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants