Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during pre-init #136

Closed
modmuss50 opened this issue Jun 13, 2018 · 4 comments
Closed

Crash during pre-init #136

modmuss50 opened this issue Jun 13, 2018 · 4 comments
Labels

Comments

@modmuss50
Copy link

modmuss50 commented Jun 13, 2018

https://gist.github.com/modmuss50/e84a837e0b560594b024c1a0f6cef96e

All mods are the latest on curse, let me know if you need more info.

My guess is its due to another mod doing something stupid (Or me being stupid by installing 700 mods).

@Elec332
Copy link
Member

Elec332 commented Jun 13, 2018

Hmmm, looks interesting.
This shouldn't be able to happen, but Ill look into it :)

@Elec332 Elec332 added the bug label Jun 13, 2018
@luke-bravenboer
Copy link

I also experienced the same exception- I can confirm that this is caused by an incompatibility with Vazkii's Player's Choice (v1.1-3).

Here's the issue I raised with his side, though it's unclear where the root cause is as of yet: VazkiiModsArchive/PlayersChoice#2

@Elec332
Copy link
Member

Elec332 commented Jun 15, 2018

I think I know what's going on

@luke-bravenboer
Copy link

luke-bravenboer commented Aug 8, 2018

Would it be feasible to simply return early if the asmData is null during the ModuleManager's preInitLast method? Since it only affects the initial fake-load cycle caused by player's choice, it shouldn't matter if things are being loaded correctly at this point

Elec332 added a commit that referenced this issue Sep 20, 2018
…132

I apologize that it took so long to fix these small issues
@Elec332 Elec332 closed this as completed Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants